Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter 4.0. Fix font-inter.rb #41

Conversation

nikitabarskov
Copy link

For some reason for InterVariable.ttf and InterVariable-Italic.ttf have been prefixed with a wrong path.
This commit fixes that.

  • brew cask audit --download {{cask_file}} is error-free.
brew cask audit --download font-inter.rb
Error: `brew cask` is no longer a `brew` command. Use `brew <command> --cask` instead
  • brew cask style --fix {{cask_file}} reports no offenses.
$ brew style --cask --fix font-inter.rb
font-inter.rb:51:3: C: FormulaAudit/Test: test do should not be empty
  test do ...
  ^^^^^^^
font-inter.rb:51:3: W: Lint/EmptyBlock: Empty block detected.
  test do ...
  ^^^^^^^

1 file inspected, 2 offenses detected

Would love to fix that as well.

  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

I do not add a new formula or cask.

For some reason for `InterVariable.ttf` and `InterVariable-Italic.ttf` have been prefixed with a wrong path.
This commit fixes that.
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label May 27, 2024
@tani tani closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants